Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return code 1 if the execution fails #140

Merged

Conversation

abhiyana
Copy link
Contributor

@abhiyana abhiyana commented Dec 1, 2023

Description:

Commit Message

fix: return code 1 if the execution fails

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@abhiyana abhiyana linked an issue Dec 1, 2023 that may be closed by this pull request
@shreyasbhat0 shreyasbhat0 changed the title fix: fix return code 1 if the execution fails fix: return code 1 if the execution fails Dec 1, 2023
@shreyasbhat0 shreyasbhat0 merged commit ff87897 into main Dec 1, 2023
1 of 2 checks passed
@shreyasbhat0 shreyasbhat0 deleted the 126-exit-code-returned-is-0-even-for-failed-para-chain branch December 1, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit code returned is 0 even for failed para chain
2 participants